Enable history undo tests
#1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkratoch
approved these changes
May 30, 2024
|
Updated the tests to match new messages. |
pkratoch
reviewed
Jun 5, 2024
|
/packit test rpm-software-management/dnf5#1452 |
One of the mark.feature tests had to disabled because its not working. Some of the steps had to be moved because `package reasons are` uses internally dnf5 which changes the last stderr output.
- group commands now accept group id instead of a name: DNF-CI-Testgroup -> dnf-ci-testgroup - dnf5 history list doesn't fill in actions: rpm-software-management/dnf5#1448 - Undoing install of dependecies that are not used by anything else is now described as `remove-unused`.
- Undoing install of dependecies that are not used by anything else is now described as `remove-unused`. - The `undo` command now has `allow_erasing` set which allows to remove `postgresql-test-9.6.8-1.module_1710+b535a823.x86_64` but it requires the `--ignore-extras` flag because it is not part of the original transaction
|
I have rebased the PR and also some of the tests needed an update. |
|
@pkratoch I think this is ready now. |
|
@kontura thanks for the update. I suppose you want to merge the last commit merge into enable undo into Enable history-undo.feature before I merge this? |
- dnf5 history list doesn't fill in actions: rpm-software-management/dnf5#1448 - Undoing install of dependecies that are not used by anything else is now described as `remove-unused`. - There is a change in one `Altered` count because dnf4 doesn't count/list `Upgraded` and `Downgraded` actions. dnf5 on the other hand shows the `Replaced` action which is their equivalent.
oh right, yes, thank you. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: rpm-software-management/dnf5#1452 and rpm-software-management/dnf5#1454